!greg 1050001197 bk-3.0.1: check -ac -f - = 0
!greg 1050001725 bk-3.0.1: check -ac -- - = 0
!greg 1050001726 bk-3.0.1: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=5868
!greg 1050002063 bk-3.0.1: check -ac -- - = 0
!greg 1050002063 bk-3.0.1: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=2178
!greg 1050031380 bk-3.0.1: check -ac -- - = 0
!greg 1050031380 bk-3.0.1: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=11715
!greg 1058383040 bk-3.0.2-rc5: check -c - = 0
!greg 1058383040 bk-3.0.2-rc5: commit -dqY/tmp/cmt2145 -f/tmp/cfiles2145 = 0
!greg 1058383061 bk-3.0.2-rc5: check -c - = 0
!greg 1058383061 bk-3.0.2-rc5: commit -dqY/tmp/cmt2193 -f/tmp/cfiles2193 = 0
!greg 1058383086 bk-3.0.2-rc5: check -c - = 0
!greg 1058383086 bk-3.0.2-rc5: commit -dqY/tmp/cmt2222 -f/tmp/cfiles2222 = 0
!greg 1058383106 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2803
!greg 1058402778 bk-3.0.2-rc5: push = 1 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1058402786 bk-3.0.2-rc5: check -acv -- - = 0
!greg 1058402786 bk-3.0.2-rc5: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=14127
!greg 1058402849 bk-3.0.2-rc5: check -acv -- - = 0
!greg 1058402849 bk-3.0.2-rc5: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=6842
!greg 1058422324 bk-3.0.2-rc5: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1058422361 bk-3.0.2-rc5: push gregkh@kernel.bkbits.net:udev = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=46579
!greg 1058510734 bk-3.0.2-rc5: check -c - = 0
!greg 1058510735 bk-3.0.2-rc5: commit -dqY/tmp/cmt29379 -f/tmp/cfiles29379 = 0
!greg 1058510748 bk-3.0.2-rc5: check -c - = 0
!greg 1058510749 bk-3.0.2-rc5: commit -dqY/tmp/cmt29416 -f/tmp/cfiles29416 = 0
!greg 1058510777 bk-3.0.2-rc5: check -c - = 0
!greg 1058510777 bk-3.0.2-rc5: commit -dqY/tmp/cmt29452 -f/tmp/cfiles29452 = 0
!greg 1058510794 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=6662
!greg 1058510846 bk-3.0.2-rc5: push gregkh@kernel.bkbits.net:udev/ = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=6662
!greg 1058555280 bk-3.0.2-rc5: check -c - = 0
!greg 1058555280 bk-3.0.2-rc5: commit -dqY/tmp/cmt32528 -f/tmp/cfiles32528 = 0
!greg 1058555435 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=82138
!greg 1058555491 bk-3.0.2-rc5: push gregkh@kernel.bkbits.net:udev = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=82138
!greg 1058555511 bk-3.0.2-rc5: pull -n bk://kernel.bkbits.net/gregkh/udev = -1 xfered=0
!greg 1058555533 bk-3.0.2-rc5: pull -n bk://kernel.bkbits.net:gregkh/udev = -1 xfered=0
!greg 1058555577 bk-3.0.2-rc5: pull -n bk://kernel.bkbits.net:gregkh/udev/foo = 1 xfered=0
!greg 1058566671 bk-3.0.2-rc5: check -acv -- - = 0
!greg 1058566672 bk-3.0.2-rc5: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=25089
!greg 1058573086 bk-3.0.2-rc5: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1058587615 bk-3.0.2-rc5: check -c - = 0
!greg 1058587616 bk-3.0.2-rc5: commit -dqY/tmp/cmt6148 -f/tmp/cfiles6148 = 0
!greg 1058587647 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=5504
!greg 1058596432 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1058596456 bk-3.0.2-rc5: push gregkh@kernel.bkbits.net:udev = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=5504
!greg 1058730528 bk-3.0.2-rc5: check -c - = 0
!greg 1058730528 bk-3.0.2-rc5: commit -dqY/tmp/cmt3620 -f/tmp/cfiles3620 = 0
!greg 1058803960 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=18504
!greg 1058804007 bk-3.0.2-rc5: push gregkh@kernel.bkbits.net:udev = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=18504
!greg 1058972155 bk-3.0.2-rc5: check -c - = 0
!greg 1058972155 bk-3.0.2-rc5: commit -dqY/tmp/cmt3010 -f/tmp/cfiles3010 = 0
!greg 1058972174 bk-3.0.2-rc5: check -c - = 0
!greg 1058972174 bk-3.0.2-rc5: commit -dqY/tmp/cmt3040 -f/tmp/cfiles3040 = 0
!greg 1058972216 bk-3.0.2-rc5: check -c - = 0
!greg 1058972216 bk-3.0.2-rc5: commit -dqY/tmp/cmt3069 -f/tmp/cfiles3069 = 0
!greg 1058976674 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=6721
!greg 1058983696 bk-3.0.2-rc5: check -c - = 0
!greg 1058983696 bk-3.0.2-rc5: commit -dqY/tmp/cmt5289 -f/tmp/cfiles5289 = 0
!greg 1058983774 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2722
!greg 1058988058 bk-3.0.2-rc5: check -c - = 0
!greg 1058988058 bk-3.0.2-rc5: commit -dqY/tmp/cmt7021 -f/tmp/cfiles7021 = 0
!greg 1058988096 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2027
!greg 1058988152 bk-3.0.2-rc5: push gregkh@kernel.bkbits.net:udev/ = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=10762
!greg 1058989047 bk-3.0.2-rc5: check -c - = 0
!greg 1058989047 bk-3.0.2-rc5: commit -dqY/tmp/cmt7348 -f/tmp/cfiles7348 = 0
!greg 1058989063 bk-3.0.2-rc5: check -c - = 0
!greg 1058989063 bk-3.0.2-rc5: commit -dqY/tmp/cmt7386 -f/tmp/cfiles7386 = 0
!greg 1058989066 bk-3.0.2-rc5: push = 1 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1058989126 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2956
!greg 1058989148 bk-3.0.2-rc5: push gregkh@kernel.bkbits.net:udev/ = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=2956
!greg 1059028026 bk-3.0.2-rc5: check -c - = 0
!greg 1059028026 bk-3.0.2-rc5: commit -dqY/tmp/cmt3521 -f/tmp/cfiles3521 = 0
!greg 1059052731 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=4262
!greg 1059056067 bk-3.0.2-rc5: push gregkh@kernel.bkbits.net:udev/ = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=4262
!greg 1059062392 bk-3.0.2-rc5: check -c - = 0
!greg 1059062392 bk-3.0.2-rc5: commit -dqY/tmp/cmt6998 -f/tmp/cfiles6998 = 0
!greg 1059062417 bk-3.0.2-rc5: check -c - = 0
!greg 1059062417 bk-3.0.2-rc5: commit -dqY/tmp/cmt7076 -f/tmp/cfiles7076 = 0
!greg 1059062432 bk-3.0.2-rc5: check -c - = 0
!greg 1059062432 bk-3.0.2-rc5: commit -dqY/tmp/cmt7113 -f/tmp/cfiles7113 = 0
!greg 1059062491 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=5218
!greg 1059062534 bk-3.0.2-rc5: push gregkh@kernel.bkbits.net:udev/ = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=5218
!greg 1059102055 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1059102108 bk-3.0.2-rc5: check -c - = 0
!greg 1059102108 bk-3.0.2-rc5: commit -dqY/tmp/cmt6240 -f/tmp/cfiles6240 = 0
!greg 1059102120 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2460
!greg 1059168636 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1060043347 bk-3.0.2-rc5: push = 1 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1060043362 bk-3.0.2-rc5: check -acv -- - = 0
!greg 1060043362 bk-3.0.2-rc5: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=26329
!greg 1060043407 bk-3.0.2-rc5: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1060268989 bk-3.0.2-rc5: check -acv -- - = 0
!greg 1060268989 bk-3.0.2-rc5: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=33388
!greg 1064527181 bk-3.0.2: check -acv -- - = 0
!greg 1064527181 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=25768
!greg 1064527192 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1065589797 bk-3.0.2: check -c - = 0
!greg 1065589797 bk-3.0.2: commit -dqY/tmp/cmt5456 -f/tmp/cfiles5456 = 0
!greg 1065589807 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=1263
!greg 1065589822 bk-3.0.2: push gregkh@kernel.bkbits.net:udev/ = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=1263
!greg 1066171658 bk-3.0.2: check -acv -- - = 0
!greg 1066171658 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=45796
!greg 1066171693 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066171779 bk-3.0.2: check -c - = 0
!greg 1066171779 bk-3.0.2: commit -dqY/tmp/cmt18008 -f/tmp/cfiles18008 = 0
!greg 1066171794 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=63529
!greg 1066263852 bk-3.0.2: check -acv -- - = 0
!greg 1066263852 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=58904
!greg 1066325135 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066335520 bk-3.0.2: check -c - = 0
!greg 1066335520 bk-3.0.2: commit -dqY/tmp/cmt4271 -f/tmp/cfiles4271 = 0
!greg 1066335547 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2173
!greg 1066335588 bk-3.0.2: push gregkh@kernel.bkbits.net:udev = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=2173
!greg 1066352645 bk-3.0.2: check -acv -- - = 0
!greg 1066352645 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=39297
!greg 1066352653 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066363421 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066363504 bk-3.0.2: check -c - = 0
!greg 1066363504 bk-3.0.2: commit -dqY/tmp/cmt6657 -f/tmp/cfiles6657 = 0
!greg 1066363513 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=1705
!greg 1066366524 bk-3.0.2: check -c - = 0
!greg 1066366524 bk-3.0.2: commit -dqY/tmp/cmt6927 -f/tmp/cfiles6927 = 0
!greg 1066366533 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=5013
!greg 1066367572 bk-3.0.2: check -c - = 0
!greg 1066367572 bk-3.0.2: commit -dqY/tmp/cmt7622 -f/tmp/cfiles7622 = 0
!greg 1066367642 bk-3.0.2: check -c - = 0
!greg 1066367642 bk-3.0.2: commit -dqY/tmp/cmt7660 -f/tmp/cfiles7660 = 0
!greg 1066367652 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2346
!greg 1066367755 bk-3.0.2: push gregkh@kernel.bkbits.net:udev = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=8514
!greg 1066368721 bk-3.0.2: check -c - = 0
!greg 1066368721 bk-3.0.2: commit -dqY/tmp/cmt7817 -f/tmp/cfiles7817 = 0
!greg 1066368740 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=4983
!greg 1066368755 bk-3.0.2: push gregkh@kernel.bkbits.net:udev = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=4983
!greg 1066436385 bk-3.0.2: pull = 1 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066436412 bk-3.0.2: check -acv -- - = 0
!greg 1066436412 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=54012
!greg 1066437775 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066596595 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!rml/greg 1066596943 bk-3.0.2: check -c - = 0
!rml/greg 1066596943 bk-3.0.2: commit -y[PATCH] udev: trivial trivialities

Yah yah, really trivial stuff...

	- get_class_device() doesn't need to be exported; it
	  should be static

	- white space cleanup
 = 0
!rml/greg 1066596981 bk-3.0.2: check -c - = 0
!rml/greg 1066596981 bk-3.0.2: commit -y[PATCH] udev: mode should be mode_t

Unix file modes should be stored in a mode_t, not a standard type.  At
the moment it is actually unsigned, in fact, not a signed integer.

Attached patch does an s/int mode/mode_t mode/ and cleans up the
results.
 = 0
!greg 1066597007 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=5122
!lkml001/greg 1066597185 bk-3.0.2: check -c - = 0
!lkml001/greg 1066597185 bk-3.0.2: commit -y[PATCH] man page update = 0
!greg 1066597196 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=3033
!greg 1066597342 bk-3.0.2: push gregkh@kernel.bkbits.net:udev = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=7880
!greg 1066597499 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066697108 bk-3.0.2: check -acv -- - = 0
!greg 1066697109 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=92292
!greg 1066717127 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066774484 bk-3.0.2: pull = 1 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066774542 bk-3.0.2: check -acv -- - = 0
!greg 1066774542 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=99662
!greg 1066778329 bk-3.0.2: check -c - = 0
!greg 1066778329 bk-3.0.2: commit -dqY/tmp/cmt4148 -f/tmp/cfiles4148 = 0
!greg 1066781700 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=1176
!greg 1066782407 bk-3.0.2: check -acv -- - = 0
!greg 1066782408 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=80403
!greg 1066782727 bk-3.0.2: check -c - = 0
!greg 1066782727 bk-3.0.2: commit -dqY/tmp/cmt4979 -f/tmp/cfiles4979 = 0
!greg 1066782742 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=1222
!greg 1066786850 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066843202 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066844260 bk-3.0.2: check -c - = 0
!greg 1066844261 bk-3.0.2: commit -dqY/tmp/cmt9945 -f/tmp/cfiles9945 = 0
!greg 1066844603 bk-3.0.2: check -c - = 0
!greg 1066844603 bk-3.0.2: commit -dqY/tmp/cmt13561 -f/tmp/cfiles13561 = 0
!greg 1066844672 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=708455
!greg 1066845051 bk-3.0.2: push gregkh@kernel.bkbits.net:udev = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=708455
!greg 1066847890 bk-3.0.2: check -c - = 0
!greg 1066847890 bk-3.0.2: commit -dqY/tmp/cmt17093 -f/tmp/cfiles17093 = 0
!greg 1066847939 bk-3.0.2: check -c - = 0
!greg 1066847939 bk-3.0.2: commit -dqY/tmp/cmt17170 -f/tmp/cfiles17170 = 0
!greg 1066847968 bk-3.0.2: check -c - = 0
!greg 1066847968 bk-3.0.2: commit -dqY/tmp/cmt17221 -f/tmp/cfiles17221 = 0
!greg 1066847994 bk-3.0.2: check -c - = 0
!greg 1066847994 bk-3.0.2: commit -dqY/tmp/cmt17266 -f/tmp/cfiles17266 = 0
!greg 1066848052 bk-3.0.2: check -c - = 0
!greg 1066848052 bk-3.0.2: commit -dqY/tmp/cmt17298 -f/tmp/cfiles17298 = 0
!greg 1066848090 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=8918
!greg 1066848321 bk-3.0.2: push gregkh@kernel.bkbits.net:udev = 0 rmts=20030410104007-07:00|kroah.com|/home/greg/src/udev/udev|greg|dHtr xfered=8918
!greg 1066848329 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066848988 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1066858250 bk-3.0.2: check -c - = 0
!greg 1066858250 bk-3.0.2: commit -dqY/tmp/cmt18310 -f/tmp/cfiles18310 = 0
!greg 1066858267 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2569
!greg 1066864393 bk-3.0.2: check -acv -- - = 0
!greg 1066864393 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=160469
!greg 1066869165 bk-3.0.2: check -acv -- - = 0
!greg 1066869165 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=149115
!greg 1067105674 bk-3.0.2: check -acv -- - = 0
!greg 1067105674 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=134493
!greg 1067271137 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1067271147 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1068607509 bk-3.0.2: check -acv -- - = 0
!greg 1068607509 bk-3.0.2: pull = 0 parent=greg@bucket:/home/greg/src/udev xfered=141364
!greg 1068608024 bk-3.0.2: check -c - = 0
!greg 1068608024 bk-3.0.2: commit -dqY/tmp/cmt3903 -f/tmp/cfiles3903 = 0
!greg 1068608103 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=1191
!greg 1068608835 bk-3.0.2: check -acfv - = 0
!kay.sievers/greg 1068608877 bk-3.0.2: check -c - = 0
!kay.sievers/greg 1068608877 bk-3.0.2: commit -y[PATCH] add uid/gid to nodes

  set uid/gid of node specified in udev.permissions
  only numeric id's are supported cause we can't resolve with
  klibc or libc before real /etc is mounted
 = 0
!kay.sievers/greg 1068608881 bk-3.0.2: check -c - = 0
!kay.sievers/greg 1068608881 bk-3.0.2: commit -y[PATCH] add support for subdirs

  support subdirectory creation/removal for NAME="/devfs/is/crazy/video0"
  create parent subdirs for device node if needed
  remove subdirs when last node is removed
 = 0
!kay.sievers/greg 1068608884 bk-3.0.2: check -c - = 0
!kay.sievers/greg 1068608884 bk-3.0.2: commit -y[PATCH] more manpage tweaks

  man page style fixes
  present the tiny udev in bold font :)
 = 0
!greg 1068609033 bk-3.0.2: check -c - = 0
!greg 1068609033 bk-3.0.2: commit -dqY/tmp/cmt6976 -f/tmp/cfiles6976 = 0
!greg 1068609055 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=6658
!greg 1068609254 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1068609275 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!dsteklof/greg 1068615444 bk-3.0.2: check -c - = 0
!dsteklof/greg 1068615444 bk-3.0.2: commit -y[PATCH] patch for libsysfs sysfs directory handling

Here's a quick patch to:

1) Add an environment variable "SYSFS_PATH" that libsysfs will check
for when getting mount point before searching system's sysfs mount
point.

2) A quick fix to sysfs_get_link where the bug was.

I have tested this out with libsysfs and with udev. I couldn't test
with klibc because I haven't got the tree to build with klibc without
my changes either. I made the link but get an error finding
linux/linits.h. I will figure that out.

Please have a look at the patch. If it's agreeable, please test it. I
really want to add some generic path manipulation functions for the
sysfs_get_link error, rather than my patch's hack. But, I haven't had
time yet to do that. You really sounded like you needed this for
testing, so I'm sending it out to you. I should probably add a
function to set the env variable(?).
 = 0
!greg 1068621453 bk-3.0.2: check -c - = 0
!greg 1068621453 bk-3.0.2: commit -dqY/tmp/cmt15568 -f/tmp/cfiles15568 = 0
!greg 1068621818 bk-3.0.2: check -c - = 0
!greg 1068621819 bk-3.0.2: commit -dqY/tmp/cmt17992 -f/tmp/cfiles17992 = 0
!greg 1068622220 bk-3.0.2: check -c - = 0
!greg 1068622221 bk-3.0.2: commit -dqY/tmp/cmt18352 -f/tmp/cfiles18352 = 0
!greg 1068622349 bk-3.0.2: check -c - = 0
!greg 1068622349 bk-3.0.2: commit -dqY/tmp/cmt19032 -f/tmp/cfiles19032 = 0
!greg 1068623096 bk-3.0.2: check -c - = 0
!greg 1068623096 bk-3.0.2: commit -dqY/tmp/cmt21379 -f/tmp/cfiles21379 = 0
!greg 1068623128 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=180024
!greg 1068623710 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1068623731 bk-3.0.2: push greg@duel:src/udev = 0 rmts=20030716110008-07:00|duel.kroah.org|/home/greg/src/udev|greg|bGda xfered=199403
!greg 1068625568 bk-3.0.2: check -c - = 0
!greg 1068625568 bk-3.0.2: commit -dqY/tmp/cmt24427 -f/tmp/cfiles24427 = 0
!greg 1068625590 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=3054
!greg 1068625752 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1068626140 bk-3.0.2: check -c - = 0
!greg 1068626140 bk-3.0.2: commit -dqY/tmp/cmt26826 -f/tmp/cfiles26826 = 0
!greg 1068626159 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=1197
!greg 1068626206 bk-3.0.2: push greg@duel:src/udev = 0 rmts=20030716110008-07:00|duel.kroah.org|/home/greg/src/udev|greg|bGda xfered=3976
!greg 1068626306 bk-3.0.2: push greg@duel:src/udev = 0 rmts=20030716110008-07:00|duel.kroah.org|/home/greg/src/udev|greg|bGda xfered=0
!greg 1068658694 bk-3.0.2: check -c - = 0
!greg 1068658694 bk-3.0.2: commit -dqY/tmp/cmt3577 -f/tmp/cfiles3577 = 0
!greg 1068658715 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2677
!greg 1068659786 bk-3.0.2: check -c - = 0
!greg 1068659786 bk-3.0.2: commit -dqY/tmp/cmt6804 -f/tmp/cfiles6804 = 0
!greg 1068659810 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=1352
!greg 1068660499 bk-3.0.2: check -c - = 0
!greg 1068660499 bk-3.0.2: commit -dqY/tmp/cmt9580 -f/tmp/cfiles9580 = 0
!greg 1068660520 bk-3.0.2: check -c - = 0
!greg 1068660520 bk-3.0.2: commit -dqY/tmp/cmt9620 -f/tmp/cfiles9620 = 0
!greg 1068660542 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=4837
!greg 1068660736 bk-3.0.2: push greg@duel:src/udev = 0 rmts=20030716110008-07:00|duel.kroah.org|/home/greg/src/udev|greg|bGda xfered=8158
!greg 1068702728 bk-3.0.2: check -c - = 0
!greg 1068702728 bk-3.0.2: commit -dqY/tmp/cmt6878 -f/tmp/cfiles6878 = 0
!greg 1068702909 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=4253
!greg 1068702931 bk-3.0.2: push greg@duel:src/udev = 0 rmts=20030716110008-07:00|duel.kroah.org|/home/greg/src/udev|greg|bGda xfered=4253
!greg 1068704649 bk-3.0.2: check -c - = 0
!greg 1068704649 bk-3.0.2: commit -dqY/tmp/cmt9354 -f/tmp/cfiles9354 = 0
!greg 1068704668 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=1045
!greg 1068705057 bk-3.0.2: check -c - = 0
!greg 1068705057 bk-3.0.2: commit -dqY/tmp/cmt9489 -f/tmp/cfiles9489 = 0
!greg 1068705276 bk-3.0.2: check -c - = 0
!greg 1068705276 bk-3.0.2: commit -dqY/tmp/cmt9627 -f/tmp/cfiles9627 = 0
!greg 1068705298 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=193700
!greg 1068705553 bk-3.0.2: push greg@duel:src/udev = 0 rmts=20030716110008-07:00|duel.kroah.org|/home/greg/src/udev|greg|bGda xfered=194470
!greg 1068705766 bk-3.0.2: push bk://linuxusb@linuxusb.bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=0
!greg 1068706884 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1068754090 bk-3.0.2: check -c - = 0
!greg 1068754090 bk-3.0.2: commit -dqY/tmp/cmt15365 -f/tmp/cfiles15365 = 0
!greg 1068754112 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=22044
!greg 1068770647 bk-3.0.2: push bk://linuxusb.adm@bkbits.net/udev = 1 xfered=0
!greg 1068770672 bk-3.0.2: push bk://linuxusb.adm@linuxusb.bkbits.net/udev = 1 xfered=0
!greg 1068770683 bk-3.0.2: push bk://linuxusb@linuxusb.bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=1667
!kay.sievers/greg 1069117167 bk-3.0.2: check -c - = 0
!kay.sievers/greg 1069117167 bk-3.0.2: commit -y[PATCH] implement printf-like placeholder support for NAME

> Problem is, if you use the LABEL rule to match a device, like a SCSI
> vendor, then all of the partitions, as well as the main block device,
> will end up with the same name.  That's why I added the "add the number"
> hack to the LABEL rule.
>
> So yes, your patch is correct in that we shouldn't always be adding the
> number to any match for LABEL (like for char devices), but if we do
> that, then we break partitions.  Your '%' patch fixes this, but I'd just
> like to extend it a bit.  Let me see what I can come up with...

Oh, I see. Do you mean something like this:

LABEL, BUS="usb", model="Creative Labs WebCam 3", NAME="webcam%n-%M:%m-test"

results in: "webcam0-81:0-test"

Nov 15 16:51:53 pim udev[16193]: get_class_dev: looking at /sys/class/video4linux/video0
Nov 15 16:51:53 pim udev[16193]: get_class_dev: class_dev->name = video0
Nov 15 16:51:53 pim udev[16193]: get_major_minor: dev = 81:0
Nov 15 16:51:53 pim udev[16193]: get_major_minor: found major = 81, minor = 0
Nov 15 16:51:53 pim udev[16193]: udev_add_device: name = webcam0-81:0-test
Nov 15 16:51:53 pim udev[16193]: create_node: mknod(/udev/webcam0-81:0-test, 020666, 81, 0)



  implement printf-like placeholder support for NAME
  %n-kernel number, %M-major number, %m-minor number
 = 0
!greg 1069117641 bk-3.0.2: check -c - = 0
!greg 1069117641 bk-3.0.2: commit -dqY/tmp/cmt14782 -f/tmp/cfiles14782 = 0
!greg 1069117669 bk-3.0.2: check -c - = 0
!greg 1069117669 bk-3.0.2: commit -dqY/tmp/cmt14820 -f/tmp/cfiles14820 = 0
!greg 1069117769 bk-3.0.2: check -c - = 0
!greg 1069117769 bk-3.0.2: commit -dqY/tmp/cmt14879 -f/tmp/cfiles14879 = 0
!greg 1069117798 bk-3.0.2: check -c - = 0
!greg 1069117798 bk-3.0.2: commit -dqY/tmp/cmt14919 -f/tmp/cfiles14919 = 0
!greg 1069117950 bk-3.0.2: check -c - = 0
!greg 1069117951 bk-3.0.2: commit -dqY/tmp/cmt14963 -f/tmp/cfiles14963 = 0
!greg 1069118111 bk-3.0.2: check -c - = 0
!greg 1069118111 bk-3.0.2: commit -dqY/tmp/cmt15015 -f/tmp/cfiles15015 = 0
!greg 1069118138 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=9261
!greg 1069118156 bk-3.0.2: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=9261
!greg 1069118522 bk-3.0.2: check -c - = 0
!greg 1069118522 bk-3.0.2: commit -dqY/tmp/cmt18103 -f/tmp/cfiles18103 = 0
!greg 1069119576 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=1301
!greg 1069140799 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1069140816 bk-3.0.2: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=1301
!greg 1069191344 bk-3.0.2: check -c - = 0
!greg 1069191344 bk-3.0.2: commit -dqY/tmp/cmt30361 -f/tmp/cfiles30361 = 0
!arnd/greg 1069191370 bk-3.0.2: check -c - = 0
!arnd/greg 1069191370 bk-3.0.2: commit -y[PATCH] add bus id modifier

On Tuesday 18 November 2003 02:14, Greg KH wrote:
> On Mon, Nov 17, 2003 at 06:33:32PM +0100, Arnd Bergmann wrote:
> > That would at least be part of the solution I'm looking for. How about
> > extra format characters for bus_id and for the result of a callout
> > program?
>
> Sure, I can see the use for that.  Want to send a patch?  :)

> Take a look at the current bk tree (which has moved to
> bk://linuxusb.bkbits.net/udev/ )  I've made finding that device a lot
> easier now, and it works for all rule types.

Great, just what I was missing. I didn't see the any link to the bk
repository. Here's the patch for the bus_id. I'll need to think about
the handling of callout results a bit more.
 = 0
!arnd/greg 1069191570 bk-3.0.2: check -c - = 0
!arnd/greg 1069191571 bk-3.0.2: commit -y[PATCH] more robust config file parsing in namedev.c

After getting a number of different crashes for udev reading broken
udev.config files, I decided to try to make the parser a little
more robust.

The behaviour is changed to stop reading the configuration file
and logging the broken entry instead of silently ignoring it (is
that good? It's easy to just print and continue).
All strcpy()'s to a fixed length string are now implicitly limited
to the bounds of the target string.

I kept the -ENODEV return code for now, not sure if there should be
different ones.
 = 0
!greg 1069191946 bk-3.0.2: check -c - = 0
!greg 1069191946 bk-3.0.2: commit -dqY/tmp/cmt614 -f/tmp/cfiles614 = 0
!greg 1069195726 bk-3.0.2: check -c - = 0
!greg 1069195726 bk-3.0.2: commit -dqY/tmp/cmt1128 -f/tmp/cfiles1128 = 0
!greg 1069195761 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=9283
!greg 1069195783 bk-3.0.2: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=9283
!chris_friesen/greg 1069201592 bk-3.0.2: commit -y[PATCH] faster test scripts

I've attached a patch against 005 for both the block and tty scripts.  I
didn't bother running udev backgrounded, since as you say, the new code
runs a lot faster.
 = 1
!greg 1069201620 bk-3.0.2: check -c - = 0
!greg 1069201621 bk-3.0.2: commit -dqY/tmp/cmt2713 -f/tmp/cfiles2713 = 0
!greg 1069201640 bk-3.0.2: check -acv -f - = 0
!greg 1069201658 bk-3.0.2: check -c - = 0
!greg 1069201658 bk-3.0.2: commit -dqY/tmp/cmt2767 -f/tmp/cfiles2767 = 0
!chris_friesen/greg 1069201662 bk-3.0.2: commit -y[PATCH] faster test scripts

I've attached a patch against 005 for both the block and tty scripts.  I
didn't bother running udev backgrounded, since as you say, the new code
runs a lot faster.
 = 1
!greg 1069201683 bk-3.0.2: check -c - = 0
!greg 1069201683 bk-3.0.2: commit -dqY/tmp/cmt2887 -f/tmp/cfiles2887 = 0
!greg 1069201712 bk-3.0.2: check -acv -f - = 0
!chris_friesen/greg 1069201716 bk-3.0.2: commit -y[PATCH] faster test scripts

I've attached a patch against 005 for both the block and tty scripts.  I
didn't bother running udev backgrounded, since as you say, the new code
runs a lot faster.
 = 1
!greg 1069201808 bk-3.0.2: check -c - = 0
!greg 1069201808 bk-3.0.2: commit -dqY/tmp/cmt3147 -f/tmp/cfiles3147 = 0
!greg 1069201816 bk-3.0.2: check -acv -f - = 0
!greg 1069202383 bk-3.0.2: check -c - = 0
!greg 1069202383 bk-3.0.2: commit -dqY/tmp/cmt8125 -f/tmp/cfiles8125 = 0
!greg 1069202439 bk-3.0.2: check -c - = 0
!greg 1069202439 bk-3.0.2: commit -dqY/tmp/cmt8244 -f/tmp/cfiles8244 = 0
!chris_friesen/greg 1069209579 bk-3.0.2: check -c - = 0
!chris_friesen/greg 1069209579 bk-3.0.2: commit -y[PATCH] faster test scripts

I've attached a patch against 005 for both the block and tty scripts.  I
didn't bother running udev backgrounded, since as you say, the new code
runs a lot faster.
 = 0
!greg 1069209880 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=7504
!greg 1069209910 bk-3.0.2: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=7504
!greg 1069210137 bk-3.0.2: check -c - = 0
!greg 1069210137 bk-3.0.2: commit -dqY/tmp/cmt8963 -f/tmp/cfiles8963 = 0
!greg 1069210169 bk-3.0.2: check -c - = 0
!greg 1069210169 bk-3.0.2: commit -dqY/tmp/cmt8999 -f/tmp/cfiles8999 = 0
!greg 1069210192 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=4605
!greg 1069210197 bk-3.0.2: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=4605
!kay.sievers/greg 1069222734 bk-3.0.2: check -c - = 0
!kay.sievers/greg 1069222734 bk-3.0.2: commit -y[PATCH] man page with included placeholder list

  mention the printf-like support for string substitution in the NAME field
 = 0
!kay.sievers/greg 1069222746 bk-3.0.2: check -c - = 0
!kay.sievers/greg 1069222746 bk-3.0.2: commit -y[PATCH] apply permissions.conf support for wildcard and default name

Permissions given in udev.permissions are not applied if no METHOD from
udev.config is found. I've added do_kernelname() to scan for known
permissions if we only use the default method.

Simple support for wildcards is also added:

#name:user:group:mode
hdb*:2702:2702:0660

results in:

drwxr-xr-x    2 root     root          240 Nov 19 03:45 .
drwxr-xr-x   23 root     root          528 Nov 17 03:36 ..
brw-r--r--    1 root     root       3,   0 Nov 19 03:45 hda
brw-r--r--    1 root     root       3,   1 Nov 19 03:45 hda1
brw-r--r--    1 root     root       3,   2 Nov 19 03:45 hda2
brw-r--r--    1 root     root       3,   4 Nov 19 03:45 hda4
brw-r-----    1 kay      kay        3,  64 Nov 19 03:45 hdb
brw-r-----    1 kay      kay        3,  65 Nov 19 03:45 hdb1
brw-r--r--    1 root     root      22,   0 Nov 19 03:45 hdc
crw-r--r--    1 root     root      81,   0 Nov 19 03:34 webcam0
 = 0
!greg 1069223898 bk-3.0.2: check -c - = 0
!greg 1069223898 bk-3.0.2: commit -dqY/tmp/cmt10432 -f/tmp/cfiles10432 = 0
!greg 1069223925 bk-3.0.2: check -c - = 0
!greg 1069223925 bk-3.0.2: commit -dqY/tmp/cmt10508 -f/tmp/cfiles10508 = 0
!greg 1069224026 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=6804
!greg 1069224042 bk-3.0.2: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=6804
!greg 1069224179 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1069224236 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1069233804 bk-3.0.2: check -c - = 0
!greg 1069233804 bk-3.0.2: commit -dqY/tmp/cmt18708 -f/tmp/cfiles18708 = 0
!greg 1069233896 bk-3.0.2: check -c - = 0
!greg 1069233897 bk-3.0.2: commit -dqY/tmp/cmt18790 -f/tmp/cfiles18790 = 0
!greg 1069233919 bk-3.0.2: check -c - = 0
!greg 1069233919 bk-3.0.2: commit -dqY/tmp/cmt18851 -f/tmp/cfiles18851 = 0
!greg 1069233939 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2998
!greg 1069234493 bk-3.0.2: check -c - = 0
!greg 1069234493 bk-3.0.2: commit -dqY/tmp/cmt19080 -f/tmp/cfiles19080 = 0
!greg 1069234552 bk-3.0.2: check -c - = 0
!greg 1069234552 bk-3.0.2: commit -dqY/tmp/cmt19248 -f/tmp/cfiles19248 = 0
!greg 1069234576 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=5883
!greg 1069234591 bk-3.0.2: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=8606
!greg 1069234616 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1069353301 bk-3.0.2: check -c - = 0
!greg 1069353301 bk-3.0.2: commit -dqY/tmp/cmt27451 -f/tmp/cfiles27451 = 0
!greg 1069353329 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2071
!greg 1069353387 bk-3.0.2: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=2071
!kay.sievers/greg 1069353415 bk-3.0.2: check -c - = 0
!kay.sievers/greg 1069353415 bk-3.0.2: commit -y[PATCH] man page with udev.permissions wildcard

here is the permissions wildcard text for the man page.
 = 0
!kay.sievers/greg 1069353421 bk-3.0.2: check -c - = 0
!kay.sievers/greg 1069353421 bk-3.0.2: commit -y[PATCH] namedev.c whitespace + debug text cleanup

here is mainly a whitespace cleanup for namedev.c. I changed the
dbg_parse() output a bit for better readability:


current:

Nov 19 19:00:59 pim udev[25582]: do_number: NUMBER path='/sys/devices/pci0000:00/0000:00:1d.1/usb2/2-1/2-1.1'
Nov 19 19:00:59 pim udev[25582]: do_number: NUMBER temp='/2-1.1' id='00:07.1'
Nov 19 19:00:59 pim udev[25582]: do_number: NUMBER temp='/2-1' id='00:07.1'
Nov 19 19:00:59 pim udev[25582]: do_number: NUMBER path='/sys/devices/pci0000:00/0000:00:1d.1/usb2/2-1/2-1.1'
Nov 19 19:00:59 pim udev[25582]: do_number: NUMBER temp='/2-1.1' id='00:0b.0'
Nov 19 19:00:59 pim udev[25582]: do_number: NUMBER temp='/2-1' id='00:0b.0'
Nov 19 19:00:59 pim udev[25582]: do_number: NUMBER path='/sys/devices/pci0000:00/0000:00:1d.1/usb2/2-1/2-1.1'
Nov 19 19:00:59 pim udev[25582]: do_number: NUMBER temp='/2-1.1' id='2-1.1'
Nov 19 19:00:59 pim udev[25582]: do_number: device id '2-1.1' becomes 'webcam%n' - owner='', group ='', mode=0


becomes:

Nov 19 19:23:40 pim udev[26091]: do_number: search '00:07.1' in '/2-1.1', path='/sys/devices/pci0000:00/0000:00:1d.1/usb2/2-1/2-1.1'
Nov 19 19:23:40 pim udev[26091]: do_number: search '00:07.1' in '/2-1', path='/sys/devices/pci0000:00/0000:00:1d.1/usb2/2-1'
Nov 19 19:23:40 pim udev[26091]: do_number: search '00:0b.0' in '/2-1.1', path='/sys/devices/pci0000:00/0000:00:1d.1/usb2/2-1/2-1.1'
Nov 19 19:23:40 pim udev[26091]: do_number: search '00:0b.0' in '/2-1', path='/sys/devices/pci0000:00/0000:00:1d.1/usb2/2-1'
Nov 19 19:23:40 pim udev[26091]: do_number: search '2-1.1' in '/2-1.1', path='/sys/devices/pci0000:00/0000:00:1d.1/usb2/2-1/2-1.1'
Nov 19 19:23:40 pim udev[26091]: do_number: found id '2-1.1', 'video0' becomes 'webcam%n' - owner='', group ='', mode=0
 = 0
!greg 1069353441 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=8590
!greg 1069353481 bk-3.0.2: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=8590
!greg 1069353714 bk-3.0.2: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=0
!greg 1069353721 bk-3.0.2: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!kay.sievers/greg 1069397249 bk-3.0.3: check -c - = 0
!kay.sievers/greg 1069397249 bk-3.0.3: commit -y[PATCH] namedev.c - change order of fields in CALLOUT

I want to bring the CALLOUT field ordering in line with the other
methods, cause the current parsing relies on the ordering it's good
to have it like the others. The BUS= is now the first expected field.

Also made the last two remaining field names to uppercase and the man page
callout example is updated.
 = 0
!kay.sievers/greg 1069397281 bk-3.0.3: check -c - = 0
!kay.sievers/greg 1069397281 bk-3.0.3: commit -y[PATCH] support arguments in callout exec

here is argument support for CALLOUT exec:

CALLOUT, PROGRAM="/bin/echo -n xxx", BUS="usb", ID="xxx", NAME="webcam%n"

results in:

Nov 20 02:35:20 pim udev[30422]: get_major_minor: found major = 81, minor = 0
Nov 20 02:35:20 pim udev[30422]: exec_callout: callout to /bin/echo -n xxx
Nov 20 02:35:20 pim udev[30422]: exec_callout: callout returned 'xxx'
Nov 20 02:35:20 pim udev[30422]: get_attr: kernel number appended: 0

The feature is really nice, but the maximum argument count is hard coded to 8.
 = 0
!greg 1069397326 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=4274
!greg 1069397329 bk-3.0.3: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=4274
!greg 1069405844 bk-3.0.3: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=0
!greg 1069525133 bk-3.0.3: check -c - = 0
!greg 1069525133 bk-3.0.3: commit -dqY/tmp/cmt3604 -f/tmp/cfiles3604 = 0
!greg 1069525155 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=3884
!greg 1069525176 bk-3.0.3: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=3884
!greg 1069566448 bk-3.0.3: check -c - = 0
!greg 1069566448 bk-3.0.3: commit -dqY/tmp/cmt5622 -f/tmp/cfiles5622 = 0
!greg 1069566473 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=5724
!greg 1069566508 bk-3.0.3: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=5724
!olh/greg 1069567101 bk-3.0.3: check -c - = 0
!olh/greg 1069567101 bk-3.0.3: commit -y[PATCH] static klibc udev does not link against crt0.o

 On Wed, Nov 19, Greg KH wrote:

> > I did 'make KLIBC=true' in the current bk tree.
>
> try 'make -f Makefile.klibc' in the current tree.  For some reason I
> couldn't figure out how to have Makefile work for both KLIBC=true and
> KLIBC=false.  But I didn't try too hard :)

I dont understand that.

please do rm -f Makefile.klibc; apply this patch and tell me what fails.
works for me.
 = 0
!greg 1069567147 bk-3.0.3: check -c - = 0
!greg 1069567147 bk-3.0.3: commit -dqY/tmp/cmt10712 -f/tmp/cfiles10712 = 0
!greg 1069567170 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=2504
!greg 1069569040 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1069569099 bk-3.0.3: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=2504
!md/greg 1069612503 bk-3.0.3: check -c - = 0
!md/greg 1069612503 bk-3.0.3: commit -y[PATCH] fix segfault in parsing bad udev.permissions file = 0
!greg 1069620281 bk-3.0.3: check -c - = 0
!greg 1069620281 bk-3.0.3: commit -dqY/tmp/cmt28687 -f/tmp/cfiles28687 = 0
!greg 1069620978 bk-3.0.3: check -c - = 0
!greg 1069620978 bk-3.0.3: commit -dqY/tmp/cmt2153 -f/tmp/cfiles2153 = 0
!greg 1069621012 bk-3.0.3: check -c - = 0
!greg 1069621012 bk-3.0.3: commit -dqY/tmp/cmt2182 -f/tmp/cfiles2182 = 0
!greg 1069621036 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=6739
!greg 1069621299 bk-3.0.3: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=6739
!kay.sievers/greg 1069622050 bk-3.0.3: check -c - = 0
!kay.sievers/greg 1069622050 bk-3.0.3: commit -y[PATCH] more namedev whitespace cleanups

attached is the last whitespace cleanup and debug text corrections.
 = 0
!kay.sievers/greg 1069622073 bk-3.0.3: check -c - = 0
!kay.sievers/greg 1069622074 bk-3.0.3: commit -y[PATCH] - format char for CALLOUT output

here is a patch for inserting the callout output into NAME=.
ID= supports the usual wildcard to compare with the output.

I've moved all wildcard matching to a function cause this was the third occurrence.
Also attached is the last whitespace cleanup and debug text corrections.
The callout patch depends on the whitespace patch.


CALLOUT, BUS="usb", PROGRAM="/bin/echo -n return", ID="ret*", NAME="webcam-%c-"

results in:

Nov 21 17:33:51 pim udev[20399]: get_major_minor: found major = 81, minor = 0
Nov 21 17:33:51 pim udev[20399]: exec_callout: callout to '/bin/echo -n return'
Nov 21 17:33:51 pim udev[20399]: exec_callout: callout returned 'return'
Nov 21 17:33:51 pim udev[20399]: get_attr: substitute callout output 'return'
Nov 21 17:33:51 pim udev[20399]: udev_add_device: name = webcam-return-
Nov 21 17:33:51 pim udev[20399]: create_node: mknod(/udev/webcam-return-, 020660, 81, 0)
 = 0
!greg 1069622254 bk-3.0.3: check -c - = 0
!greg 1069622254 bk-3.0.3: commit -dqY/tmp/cmt2886 -f/tmp/cfiles2886 = 0
!greg 1069622277 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=5353
!greg 1069622297 bk-3.0.3: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=5353
!greg 1069626313 bk-3.0.3: check -c - = 0
!greg 1069626313 bk-3.0.3: commit -dqY/tmp/cmt7113 -f/tmp/cfiles7113 = 0
!greg 1069626334 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=5212
!greg 1069626542 bk-3.0.3: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=5212
!greg 1069630779 bk-3.0.3: check -c - = 0
!greg 1069630779 bk-3.0.3: commit -dqY/tmp/cmt7614 -f/tmp/cfiles7614 = 0
!greg 1069630799 bk-3.0.3: check -c - = 0
!greg 1069630799 bk-3.0.3: commit -dqY/tmp/cmt7652 -f/tmp/cfiles7652 = 0
!greg 1069630839 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=3096
!greg 1069630952 bk-3.0.3: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=3096
!greg 1069631859 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=0
!greg 1069632190 bk-3.0.3: check -c - = 0
!greg 1069632190 bk-3.0.3: commit -dqY/tmp/cmt8290 -f/tmp/cfiles8290 = 0
!greg 1069632204 bk-3.0.3: check -c - = 0
!greg 1069632204 bk-3.0.3: commit -dqY/tmp/cmt8328 -f/tmp/cfiles8328 = 0
!greg 1069632251 bk-3.0.3: push = 0 parent=greg@bucket:/home/greg/src/udev xfered=3702
!greg 1069632255 bk-3.0.3: push bk://linuxusb@bkbits.net/udev = 0 rmts=20031112234106-08:00|hostme.bitkeeper.com|/repos/l/linuxusb/udev|linuxusb.adm|LZYw xfered=3702
